refactor!: Rename ImpersonateUserOptions to CreateUserImpersonationRequest and pass by value - #4462
Merged
Merged
Conversation
`CreateUserImpersonationRequest` and pass by value BREAKING CHANGE: `AdminService.CreateUserImpersonation` now takes `CreateUserImpersonationRequest` by value instead of `*ImpersonateUserOptions`. `Scopes` is required and no longer uses `omitempty`.
jvm986
marked this pull request as ready for review
August 20, 2026 15:57
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4462 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 194 194
Lines 17603 17603
=======================================
Hits 17342 17342
Misses 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
added
the
Breaking API Change
gmlewis
approved these changes
Aug 20, 2026
gmlewis
left a comment
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @jvm986 and @stevehipwell!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the request-body-by-value work in #3644, this time for
AdminService.CreateUserImpersonation.The type had an
Optionssuffix despite being a POST body, and was passed by pointer even though its only parameter,scopes, is required. It's renamed after the operation, passed by value, andScopesdropsomitempty. Removed from bothparamcheckallowlists (body-allowed-pointer-typesandbody-allowed-wrong-names).BREAKING CHANGE:
AdminService.CreateUserImpersonationnow takes a newCreateUserImpersonationRequest(with non-pointer Scopes) by value instead of*ImpersonateUserOptions.cc @JamBalaya56562 @ManavSharma142 @stevehipwell